search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.26k stars 830 forks source link

[Docs] Missing guidelines for 12px icons #936

Closed lukasoppermann closed 1 year ago

lukasoppermann commented 1 year ago

I am in need of a 12px icon I want to contribute and noticed that the guidelines only specify how to create 16px and 24px icons: https://primer.style/design/foundations/icons/design-guidelines

It would be great if 12px guidelines could be included as well.

tallys commented 1 year ago

Hey @lukasoppermann the 12px icons were an exception, and we are only supporting 16px and 24px sizes. If this is for a specific icon for a product, fill out an issue template and we can work through it in an upcoming working session.

lukasoppermann commented 1 year ago

Hey @lukasoppermann the 12px icons were an exception, and we are only supporting 16px and 24px sizes.

Makes sense, but two points:

  1. Shouldn't we mention exactly this somewhere? As the first thing you see on the overview page are the 12px icons
  2. I needed a product specific 12px icon, so wouldn't it still be good to know how to design it if needed?

If this is for a specific icon for a product, fill out an issue template and we can work through it in an upcoming working session.

I did this any way (https://github.com/github/primer/issues/1965) and have added the icon to figma via a PR.