primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.26k stars 830 forks source link

[Icon request] Unpin #940

Closed yp05327 closed 1 year ago

yp05327 commented 1 year ago

Describe the topic

Could you add an unpin icon?

Anything else?

Thank you for this pretty icon set

gavinmn commented 1 year ago

Thanks for the request @yp05327 — I'll pass this along to the internal team!

silverwind commented 1 year ago

Current pin icon is

Screenshot 2023-04-17 at 17 08 01

My idea would a same icon, but with a strike-through, similar to these:

Screenshot 2023-04-17 at 17 08 27
CameronFoxly commented 1 year ago

I've started thinking about adding this request to the library, and realized that we'll have to flip the direction of our pin icon, so that the slash follows the same directional conventions (slashing from top left to bottom right) of the rest of the library. This also actually seems like the right move for the pin icon because more of the icons in the library that have a diagonal composition tilt the way the the flipped version of the pin icon would (with the tip of the pin pointing left instead of right).

Here's my proposed solution for both an updated pin and the new unpin, at 2x and 1x in both 16px and 24px sizes:

Image

@tallys, can you check with product owners to make sure swapping the direction of the pin icon wouldn't be problematic?

tallys commented 1 year ago

~Will follow up! Thanks @CameronFoxly~

Ship it 🚀

CameronFoxly commented 1 year ago

A new release went out this morning which has included the pin-slash icon. It can be seen here and is now included in the library and npm package. Thanks for the request, @yp05327.

Closing this out 🚀