primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.26k stars 830 forks source link

Update Icons to use `React.forwardRef` & Remove support for `Octicon` #943

Closed broccolinisoup closed 1 year ago

broccolinisoup commented 1 year ago

Closes #910

As stated in the issue itself, our icon components do not forward their refs and this is currently causing issues in the remediated Tooltip implementation https://github.com/primer/react/pull/3032. It is also a great enhancement for future cases to make sure their refs are available to access when needed.

Re introducing this change as a major, please see the comment

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: ac2dc3fbd425e55f526fa3a59cdaf7e37bfd39c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR