primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.34k stars 829 forks source link

Save pin-16.svg, pin-slash-16.svg, pin-24.svg, pin-slash-24.svg #950

Closed CameronFoxly closed 1 year ago

CameronFoxly commented 1 year ago

This PR adds pin-slash (alt keyword unpin) and flips the orientation of our current pin icon to make them work together. Discussion in this issue.

Screen Shot 2023-05-10 at 11 34 40 AM

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 71e0f88a7cc510fdc3d8514696a9d3702e08068a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

colebemis commented 1 year ago

@CameronFoxly I think you need to remove the frame background in Figma. When the SVG optimizer runs, the frame background turns into a black square:

CleanShot 2023-05-10 at 11 57 33@2x
CameronFoxly commented 1 year ago

Thanks for the headsup @colebemis. Should be good now!