search

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.26k stars 830 forks source link

[Feedback] No empty/unchecked checkbox to go with "checkbox" icon? #955

Closed rahji closed 1 year ago

rahji commented 1 year ago

Describe the topic

There is a "checkbox" icon, but no corresponding unchecked box icon.

Anything else?

tallys commented 1 year ago

Hi @rahji, thanks for opening the issue. The icons are intended to be visual language to enhance UI, bot not interactive. The Octicons set has the square icon, but we intentionally choose not have an empty toggle checkbox. Including it could potentially encourage inaccessible checkboxes being built in the UI. If you need a checkbox, see https://primer.style/react/Checkbox.

rahji commented 1 year ago

That makes sense. I think the use case that I have matches up with what you're saying, actually. The Todo Tree vscode extension uses Octicons as indicators in the gutter (not interactive at all). It's nice to be able to indicate both comments that are yet to be done and those that are completed. I'm using other icons instead, but empty and checked boxes would have been ideal for this situation -- actually, I'm not sure how circles and checked circles is unlike checked/unchecked boxes, but please don't take them away! :) In any case, thanks for the reply.

image