primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.26k stars 830 forks source link

Add undo / redo icons #956

Closed gavinmn closed 1 year ago

gavinmn commented 1 year ago

closes https://github.com/github/primer/issues/2163

CleanShot 2023-06-01 at 08 47 01@2x undoredoui
changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: b471d503c3b65811c24591f19fdc0d5fe95b8480

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------- | ----- | | @primer/octicons | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

colebemis commented 1 year ago

How do you feel about adding a little more space between the tail and the arrowhead?

CleanShot 2023-06-09 at 10 25 53@2x

Here are some under/redo icons I designed for Primer Prism that demonstrate what I mean:

CleanShot 2023-06-09 at 10 25 25@2x
iansan5653 commented 1 year ago

Purely opinionated thought: Do you think maybe they are visually weighted too much toward the arrowhead? To me they kind of feel like they look like they are about to tip over, especially with a larger gap 😄. Maybe a smaller arrowhead and longer tail that goes all the way to the left?

gavinmn commented 1 year ago

Just pushed these changes:

CleanShot 2023-06-09 at 14 12 32@2x

I widened the radius of the turn to get some more separation between the end of the arrow and the tail. The bottom preview included is an example of the tail going further across. I feel like this causes the icon to loose the "swoop" feeling that gives the "undo" feeling and it ends up looking more like "u turn" to me.