primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.22k stars 829 forks source link

[Bug] Discrepancies Between Figma Octicons Set and React Library #973

Closed JonathanXDR closed 4 months ago

JonathanXDR commented 11 months ago

Describe the bug

The Figma community page for the Octicons icon set seems to be outdated, leading to discrepancies between the icons (including their different sizes) available in the Figma set and the current Primer Octicons library. E.g. the Paintbrush Octicon with a size of 24px, present in the Figma set, is absent in the React library.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to the official Figma community page for Octicons: Octicons - GitHub's icon set (Community)
  2. Observe the set of icons available, especially the Paintbrush icon with a size of 24px.
  3. Compare the Figma set with the React library.
  4. Notice the absence of some icons, like the Paintbrush, in the React library.

Expected behavior

The Figma set and the React library should be in sync, with the same set of icons & sizes available in both. If there are icons present in the Figma set that are not in the library (or vice versa), this should be clearly documented.

Screenshots

Octicon overview in Figma

octicon overview in figma

Octicon overview in the Primer documentation

octicon overview in the primer documentation

Device details

Desktop:

Additional info

The attached screenshots can be referenced for the current set of icons in Figma & the React library. It would be beneficial for developers and designers to have a consistent set of icons across all platforms and documentation.

tallys commented 11 months ago

@JonathanXDR thanks for opening the issue - sending it to the Octicon working group inbox

github-actions[bot] commented 4 months ago

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

JonathanXDR commented 4 months ago

@tallys and @lukasoppermann, could we reopen the issue until all reviewers of #983 have approved and the PR was merged?