Add new Feed icons - Githubissues

primer / octicons

A scalable set of icons handcrafted with <3 by GitHub

https://primer.style/foundations/icons

MIT License

8.22k stars 829 forks source link

Add new Feed icons #977

Closed gavinmn closed 11 months ago

gavinmn commented 11 months ago

Closes https://github.com/github/primer/issues/2529

Adds a handful of new Feed icons

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: e2024d2f272b116f9e399f60a8d843cd8737acd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ---------------- | ----- | | @primer/octicons | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

marcalcobe commented 10 months ago

Hi @gavinmn and @tallys ,

When adding this new icons to our library of Octicons in Figma (to keep it updated), I've noticed that two of the issue icons are called the same "feed-issue-open" resulting with the package only containing the icon that looks like reopen.

What is the normal procedure in this cases? Should I open a separate issue for this?

gavinmn commented 10 months ago

@marcalcobe thank you for reporting this! I should have a fix ready to go in https://github.com/primer/octicons/pull/980