primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.22k stars 829 forks source link

Bump rubocop and rubocop-github #994

Closed HDinger closed 5 months ago

HDinger commented 7 months ago

Problem

Currently, on every PR the CI is failing on the gem:octicons_helper step when Linting with the following error: wrong number of arguments (given 5, expected 1). This happens due to the rubocop gem being outdated quite some bit.

Examples

See the currently opened PR:

Solution

The rubocop and the rubocop-github gems are updated to the current versions.

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: e69c0394d04bb468bae9f33e93e87e31963d8b89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 5 months ago

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.