primer / octicons

A scalable set of icons handcrafted with <3 by GitHub
https://primer.style/foundations/icons
MIT License
8.29k stars 827 forks source link

[Bug] The SVGs in /build/svg/ don't have the `octicon` classes attached #997

Closed fregante closed 3 months ago

fregante commented 9 months ago

Describe the bug

The classes:

Expected behavior

Could you include the octicon octicon-something classes in the built SVGs?

I only need this in @primer/octicons, but the issue also appears in @primer/octicons-react (however I don't understand the point of the built SVG files in that package since they're not allowed by the exports map)

Context

I want to import the raw SVGs in my extensions

fregante commented 9 months ago

So this is because the icons are plainly copied from the ./icons folder, which understandably doesn't have any extraneous attributes.

This issue doesn't affect me anymore though, I'm using https://github.com/fregante/octicons-plain-react

github-actions[bot] commented 3 months ago

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.