primer / primitives

Color, typography, and spacing primitives in json.
https://primer.style/primitives
MIT License
311 stars 43 forks source link

Docs: Fix broken and incomplete storybook stories #1063

Closed francinelucca closed 2 months ago

francinelucca commented 2 months ago

Summary

Saw some broken stories in our docs/storybooks, some examples:

And some stories with missing information (mainly source value):

Looks like at some point the .json info files renamed property from value to $value, adjusting stories to reflect that.

List of notable changes:

What should reviewers focus on?

Steps to test:

  1. Open the preview documentation that has been deployed in this pull request
  2. Verify token stories correctly display source value and that previously listed "broken" stories are now able to render

Supporting resources (related issues, external links, etc):

Contributor checklist:

Reviewer checklist:

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 7c5767f26f5cac50c7c5808e68da639dd1cda37c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lukasoppermann commented 2 months ago

Great catch!