search

primer / primitives

Color, typography, and spacing primitives in json.
https://primer.style/primitives
MIT License
304 stars 44 forks source link

Low contrast for ANSI colors #72

Closed dominicegginton closed 3 years ago

dominicegginton commented 3 years ago

Not sure if this is a primitives issue but am opening just in case

GItHub's VSCode theme uses primers primitives ANSI color values for the integrated terminal color theme. There are several open issues in regards to low contrast (mostly pointing to the GitHub Light Default theme) rendering some text unreadable. Is this something the primer team can look into?

Please see https://github.com/primer/github-vscode-theme/issues/157 & https://github.com/primer/github-vscode-theme/issues/155

Screenshots

GitHub Light Default GitHub Dark Default GitHub Dark Dimmed
screenshot-Sat-17Apr21_00 17 screenshot-Sat-17Apr21_00 18 screenshot-Sat-17Apr21_00 18_000
simurai commented 3 years ago

Was wondering about the low contrast in VS Code's terminal too and I think the problem is that on github.com the Checks (that use the ANSI colors) have a "custom" dark background in light mode:

Screen Shot 2021-04-19 at 10 29 15

So the ANSI colors in light mode are kinda meant for a dark mode which doesn't really work outside of github.com. 🤔

Hmmm.. maybe we can look into a way where we can have a "permanent theme" (dark checks in light mode)? I guess as a short term fix we could add custom checks-ansi colors that work for dotcom and change the existing ansi colors to work on a light background.