primer / prism

A tool for creating and maintaining cohesive, consistent, and accessible color palettes
https://primer.style/prism/
MIT License
667 stars 39 forks source link

Add delete button on palette card #24

Closed mohitkyadav closed 2 years ago

mohitkyadav commented 2 years ago

Fixes #20

Screenshot 2022-06-22 at 7 11 01 AM

CHANGELOG

Added

netlify[bot] commented 2 years ago

Deploy Preview for primer-prism ready!

Name Link
Latest commit 5aa57e281ba8ead469e62ec2fb73f510bab48eac
Latest deploy log https://app.netlify.com/sites/primer-prism/deploys/62ac4c74e3634f000934acb0
Deploy Preview https://deploy-preview-24--primer-prism.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mohitkyadav commented 2 years ago

@colebemis please review.

mohitkyadav commented 2 years ago

@colebemis still waiting over here 👋.

colebemis commented 2 years ago

Thanks for your patience, @mohitkyadav! Hoping to find time to merge this today

stevenpetryk commented 2 years ago

I'm not sure if this is really necessary—how often do users delete palettes? It's quite a bit of clutter for potentially not much benefit.

stevenpetryk commented 2 years ago

I think this will cause prettier to fail on main btw—it was opened before #22 was merged so Prettier isn't running in CI yet. Prettier isn't running in CI and this code hasn't been formatted.

mohitkyadav commented 2 years ago
  1. Updated the colour of the delete button.
  2. Moved the button outside of the card.
  3. palette title now truncates.
  4. All cards persist same height.
Screenshot 2022-06-22 at 7 11 01 AM