search

primer / prism

A tool for creating and maintaining cohesive, consistent, and accessible color palettes
https://primer.style/prism/
MIT License
667 stars 39 forks source link

Blank screen after deleting a scale color #35

Closed damidina closed 2 years ago

damidina commented 2 years ago

Describe the bug When I select a scale and delete a color the page goes blank

To Reproduce Steps to reproduce the behavior:

  1. Go to prism
  2. Create a new palette or go to an existing palette
  3. Select an existing scale or add a new sacle
  4. On the right panel select delete color for the scale (screenshot below)
image

Expected behavior Not exactly sure but the page probably shouldn't go blank

Screenshots

image image

Environment Chrome Version 102.0.5005.115 (Official Build) (x86_64) Mac OS Catalina - Version 10.15.7

Additional context Posted a video here: https://twitter.com/DamiDina/status/1539291589847171073

colebemis commented 2 years ago

Looks like it only breaks when deleting the last color in the scale. @pavelkeyzik I think this is related to the bug your reported and fixed: https://github.com/primer/prism/issues/10

@pavelkeyzik Could you disable the "Delete color" button if the color is the last color in the scale?

pavelkeyzik commented 2 years ago

@colebemis I'll take a look in few hours. Thanks for reporting @damidina ❤️

pavelkeyzik commented 2 years ago

@damidina The issue should be resolved. You can try to reproduce it again. If you're happy with the result, you can close the issue. If not, just let us know 😊