primer / react

An implementation of GitHub's Primer Design System using React
https://primer.style/guides/react
MIT License
3.14k stars 535 forks source link

Overlay component box shadows in dark and dimmed modes #1278

Closed pmarsceill closed 3 years ago

pmarsceill commented 3 years ago

Describe the bug Using the overlay component in dark and dimmed mode doesn't adjust the box shadow to the proper values. On Dotcom, we use different box shadows for dark modes:

image

Currently PRC uses the same shadows for dark and light modes which makes the dropdown look like it's foggy and sad in dark modes:

image

Note: As this is a public repo, please be careful not to include details or screenshots from unreleased GitHub products or features. In most cases, a good bug report should be able to describe the new component without including business logic or feature details, but if you must discuss context relating to an unreleased feature, please open an issue in the private Design Systems repo and link to it here.

To Reproduce Use an overlay component in dark mode

Expected behavior Same dropshadow for dark mode as we use on Dotcom

Desktop (please complete the following information): n/a

Smartphone (please complete the following information): n/a

bscofield commented 3 years ago

https://github.com/primer/components/pull/1279