search

primer / react

An implementation of GitHub's Primer Design System using React
https://primer.style/guides/react
MIT License
3.16k stars 536 forks source link

ThemeProvider: Deprecate redundant day and night color modes #3246

Open siddharthkp opened 1 year ago

siddharthkp commented 1 year ago

Description

primer/react supports more options for color modes than primer/primitives does

color modes for primer/primitives: auto | light | dark color modes for primer/react: auto | day | night | light | dark

this is because day and night color modes are equivalent to light and dark which causes confusion. We should deprecate them in the next major.

Usage in dotcom →

Version

v35

colebemis commented 1 year ago

I wonder if we should hold off from making any breaking changes to ThemeProvider until we have a new theming API implemented with the new styling architecture. Seems unnecessary to make consumers update their ThemeProvider in v36 if it's going to change shortly after.

joshblack commented 1 year ago

Hey you two! Just wanted to double-check with you all if this would be a good one to include or defer for v36 👀 cc @siddharthkp @colebemis

github-actions[bot] commented 11 months ago

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

github-actions[bot] commented 5 months ago

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.