Closed ktravers closed 2 weeks ago
Latest commit: a44d6a04c80c364f5613e7f62866bf6d42e4f851
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Path | Size |
---|---|
packages/react/dist/browser.esm.js | 89.46 KB (0%) |
packages/react/dist/browser.umd.js | 89.73 KB (0%) |
I am merging this so that I can include it in the current release! Thanks again 🙌🏻
Closes https://github.com/github/primer/issues/3331
This pull request introduces support for styling via CSS utility classes on the
PageHeader
component and its children by adding support for an optionalclassName
prop, allowing for more flexible customization without relying on Styled System props (sx
). Full context: my team is currently in the process of deprecating our use ofsx
, so this change will allow us to safely incrementally replacesx
props withclassName
props.Changelog
New
className
prop: AllPageHeader
components now accept aclassName
prop. This prop is applied to the root element of each component.className
prop is optional and does not affect existing implementations that do not use this prop.PageHeader
components have been updated to include the newclassName
prop, ensuring type safety for TypeScript users.PageHeader
component documentation has been updated to include information about the newclassName
prop.Changed
N/A
Removed
N/A
Rollout strategy
Testing & Reviewing
Prerequisites
npm run setup
to setup dependenciesClick testing
npm start
to start the Storybook serverPageHeader
component in StorybookAutomated testing
npx playwright install --with-deps
to install dependenciesnpx playwright test --grep @vrt
to run visual regression testsnpx playwright test --grep @art
to run accessibility testsMerge checklist