primer / react

An implementation of GitHub's Primer Design System using React
https://primer.style/guides/react
MIT License
3.12k stars 535 forks source link

fix(Spinner): use aria-label when defined, falling back to srText #4685

Closed joshblack closed 3 months ago

joshblack commented 3 months ago

Resolve an issue that is showing up in: https://github.com/github/github/pull/329788 where Spinner will always use srText instead of the provided aria-label.

Changelog

New

Changed

Removed

Rollout strategy

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: e01be700a1dc4b2b8feacbcf6fed548033d42bba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.8 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 91.16 KB (+0.1% 🔺)
joshblack commented 3 months ago

@jonrohan good call, added!