primer / react

An implementation of GitHub's Primer Design System using React
https://primer.style/guides/react
MIT License
3.12k stars 535 forks source link

Fix `ActionList.Item` conditional when FF is not enabled #4695

Closed TylerJDev closed 3 months ago

TylerJDev commented 3 months ago

Changelog

Changed

Fixes conditional when primer_react_action_list_item_as_button feature flag is not enabled. This allows the forwarded ref to always be present, regardless of the FF being active or not. If the FF is inactive, it defaults to providing the <li> the ref. When the FF is active, applies it to either the <li> or the <button> based on the listSemantics const.

Rollout strategy

Testing & Reviewing

Merge checklist

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 2a68038ff9ad7713786b28b9b0e0406fe8e785d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | @primer/react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.01 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js 91.37 KB (+0.03% 🔺)