primer / react

An implementation of GitHub's Primer Design System using React
https://primer.style/guides/react
MIT License
3.02k stars 520 forks source link

IconButton: Add `keyshortcuts` prop to allow labelling and describing support for keyboard shortcut (through tooltips) #4707

Open broccolinisoup opened 2 days ago

broccolinisoup commented 2 days ago

This PR proposes an addition to the icon button API as it is accepted on https://github.com/github/primer/pull/2650 (internal link only). The keyshortcuts prop is added to the IconButton component to allow labelling and describing support for keyboard shortcuts through tooltips. This change is beneficial as it provides a more accessible user experience.

Changelog

New

Changed

Rollout strategy

Testing & Reviewing

Merge checklist

changeset-bot[bot] commented 2 days ago

🦋 Changeset detected

Latest commit: fd0123e3b9d8b82761c9cdbfeaa2bd0d0be9dd8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------- | ----- | | @primer/react | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 days ago

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.02 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 91.41 KB (+0.18% 🔺)