Link underlines are rendered on hover even when underline:false is specified

[lesliecdubs]

@camertron This has resulted in underlines being rendered on hover when underline:false is set. Before the .no-underline class would prevent underline on hover as well.

_Originally posted by @kintner in https://github.com/primer/view_components/issues/2249#issuecomment-1747876835_

[github-actions[bot]]

Uh oh! @lesliecdubs, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

[github-actions[bot]]

Uh oh! @lesliecdubs, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

[kintner]

I'm wondering if we should just add .no-underline to our links to fix this...

[lesliecdubs]

Notes from PVC sync:

• It looks like the default behavior of PRC links is having no underline by default, on hover underline appears: https://primer.style/react/storybook/?path=/story/components-link--default
• In https://github.com/primer/view_components/pull/2249, this same behavior was replicated in PVC

I think we could use some Primer Design input on whether this is the preferred behavior for underlines on links or not.

[tallys]

Let's discuss this at an upcoming patterns meeting, also cc @lukasoppermann and @ericwbailey

[camertron]

I can provide some context on this. We decided to allow no underline on links, but always underline links on hover. My understanding is that links are more accessible when they are distinguished visually by more than just color alone.

[jonrohan]

@kintner After discussing in the primer patterns meeting, the recommended fix here is to replace these 2 links with Button components with the invisible scheme https://view-components-storybook.eastus.cloudapp.azure.com/view-components/lookbook/inspect/primer/beta/button/leading_visual