primer / view_components

ViewComponents for the Primer Design System
https://primer.style/components/
MIT License
449 stars 113 forks source link

Dialog spacings between content and header in Rails #3008

Open marcalcobe opened 1 month ago

marcalcobe commented 1 month ago

Pain point

Screenshots

- Rails with divider:

Screenshot 2024-08-15 at 12 19 12

- Rails without divider:

Screenshot 2024-08-15 at 12 19 21

- React:

Screenshot 2024-08-15 at 12 19 31

I know that this might be a design decision, so I'd would like to understand why is it different in React vs Rails.

github-actions[bot] commented 1 month ago

Uh oh! @marcalcobe, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

lesliecdubs commented 1 month ago

👋 Hi, thanks for reporting this! I don't believe this was an intentional design decision.

The Dialog component is still in Alpha. This kind of improvement would be something we could take a look at rectifying if we invest in bringing Dialog to Beta. In the meantime, we would recommend manually adding some padding to the dialog contents.