primer / view_components

ViewComponents for the Primer Design System
https://primer.style/components/
MIT License
449 stars 114 forks source link

[SelectPanel] Raise an error when remote fetch + hidden filter combo #3053

Closed camertron closed 1 week ago

camertron commented 1 week ago

What are you trying to accomplish?

This PR raises an error if the filter input is hidden and the fetch strategy is :remote (the default). This is an invalid state the component should actively guard against.

Integration

No updates necessary in production - nobody is using this particular combo of options at the moment.

List the issues that this change affects.

Fixes https://github.com/github/primer/issues/3895

Risk Assessment

Accessibility

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 4553969306e8f3822ffb0c12690bebf4396d4d01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------- | ----- | | @primer/view-components | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR