SegementedControl has the wrong color - Githubissues

primer / view_components

ViewComponents for the Primer Design System

https://primer.style/components/

MIT License

475 stars 116 forks source link

SegementedControl has the wrong color #3075

Closed HDinger closed 1 month ago

HDinger commented 1 month ago

Steps to reproduce

Create a segmented control with icons and text:

render(Primer::Alpha::SegmentedControl.new("aria-label": "File view", size: :medium)) do |component|
  component.with_item(label: "Preview", icon: :eye, selected: true)
  component.with_item(label: "Raw", icon: :"file-code")
  component.with_item(label: "Blame", icon: :people)
end

Actual behavior

The text is rendered in blue
I assume that happend with the update to primitives v9 in the last version. Before it worked correctly

Bildschirmfoto 2024-09-10 um 11 40 42

Expected

The text should be black

Bildschirmfoto 2024-09-10 um 11 41 37

Environment

OS: MacOs
Browser: Chrome/Firefox
Primer version: 0.33.0 ( was introduced just recently, in 0.31.0 it worked fine)

jonrohan commented 1 month ago

We're having trouble reproducing this, could you verify it's still broken and share a link if you have it?

HDinger commented 1 month ago

I can't reproduce this any more either. 🤷‍♂️ Thanks for having a look 🙇