primer / view_components

ViewComponents for the Primer Design System
https://primer.style/components/
MIT License
475 stars 116 forks source link

Add "action" to the list of data attributes that accept multiple values #3076

Closed HDinger closed 3 weeks ago

HDinger commented 1 month ago

What are you trying to accomplish?

The current attribtue helper method merge_data has defined some keys that accept multiple values and adds some after each other devided by a space. This PR adds action to the list of the allowed keys.

Integration

No

Risk Assessment

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 39dec4e8435dea703a4229070969b080690d21f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------- | ----- | | @primer/view-components | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

HDinger commented 1 month ago

Hey folks :) Any feedback on this?

HDinger commented 3 weeks ago

@keithamus Can we merge this then?