primer / view_components

ViewComponents for the Primer Design System
https://primer.style/components/
MIT License
475 stars 116 forks source link

Are there any accessibility considerations we should list for `Breadcrumbs`? #809

Closed khiga8 closed 3 years ago

khiga8 commented 3 years ago

Relates to https://github.com/github/primer/issues/261

The description for the component in PVC is barebones right now but will be consolidated to match Primer CSS Breadcrumbs and Primer React Breadcrumbs.

Aside from the general description, are there any accessibility considerations we should note specifically for PVC usage?

cc: @alliethu

khiga8 commented 3 years ago

I don't think there's anything specific the consumer needs to handle. If the component is already taking care of accessibility attributes, is it something we should note anyways, or is it "expected"? 🤔

alliethu commented 3 years ago

As long as we are covering the Interface Guidelines in the design hub, I don't think there's a need for more info in the PVC docs.

I don't think there's anything specific the consumer needs to handle. If the component is already taking care of accessibility attributes, is it something we should note anyways, or is it "expected"?

@khiga8 good question. If all of our docs (PVC, PRC, PCSS, IG) were consolidated into one place, I'd say there wouldn't be a need to mention the attributes. However, because they aren't, I feel it's worth mentioning the ARIA usage from an education/awareness standpoint to better explain what's going on under the hood.

khiga8 commented 3 years ago

because they aren't, I feel it's worth mentioning the ARIA usage from an education/awareness standpoint to better explain what's going on under the hood.

@alliethu Good point! I'll do that! :-)