Fixes - Githubissues

primetang / pylsd

python bindings for LSD - Line Segment Detector.

Other

159 stars 63 forks source link

Open kba opened 5 years ago

kba commented 5 years ago

Replace ad-hoc tempfile solution with tempfile module
Make sure lsdGet is being passed bytes not a string (or it will try to write to / and fail)
library warning to contain filename in case it does fail to write
fix the examples
pad setup.py to contain the README e.g.

Published updated version as ocrd-fork-pylsd at https://pypi.org/project/ocrd-fork-pylsd/. Install it with pip:

pip install 'ocrd-fork-pylsd == 0.0.3'

bertsky commented 3 years ago

@kba I recommend removing 73648c6 from this PR branch, because upstream would not want to call their package ocrd-fork-pylsd. So could you please remove the latest commit (and force-push) and instead merge https://github.com/kba/pylsd/tree/fixes into https://github.com/kba/pylsd/tree/pypi-fork?

kba commented 3 years ago

73648c6 is gone now and pypi-fork up-to-date.