primetoxinz
commented
1 year ago Hey, honestly I have no intention of doing any additional work on this mod myself. If you are interested making your suggested improvements, by all means send a pull request.
Hello,
If you want to add TFC compatibility, you probably should change this line because, if I understood their code right, TFC water has a different material. Maybe one want to check if the block is a fluid. Its there: https://github.com/primetoxinz/CoralReef/blob/c85080f4d9a63e7a46e0244ff82e038152afc9fb/src/main/java/primetoxinz/coralreef/BlockCoral.java#L84 Maybe you can add something like this (Idk how it would be in 1.12.2 but probably not that different): https://stackoverflow.com/questions/70938395/check-if-block-is-any-liquid-minecraft-forge-1-18-1
The corals get placed but they also get destroyed autonatically if you are not far away from them. I think it is because of the canBlockStay method. Maybe you should have two seperate methods, because in world gen the corals are created correctly, I guess you are using this method? You could also check the block properties or exclude lava instead of checking if it is water. Maybe it would be the best to let the user pick liquids in the config.
Best regards