fix: retry on failed event subscription

primev / mev-commit

establishes a p2p network, allowing mev actors to issue bids and commitments for execution in real time

https://docs.primev.xyz/

Other

35 stars 1 forks source link

fix: retry on failed event subscription #384

Closed aloknerurkar closed 2 months ago

aloknerurkar commented 2 months ago

Describe your changes

Retry subscription to logs on error. Allow sufficient time before we declare error.

Issue ticket number and link

Fixes # (issue)

Checklist before requesting a review

[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have made corresponding changes to the documentation

aloknerurkar commented 2 months ago

I would suggest considering this package to simplify the solution and make it more robust: https://github.com/cenkalti/backoff

I am not really sure if we need exponential backoff here. This is currently problem with connection to our settlement layer. We dont really have any rate-limiting on geth. So the only reason I see this dropping is because of connection drop on client side. So not sure if exponential backoff will help. Wdyt?

mrekucci commented 2 months ago

I would suggest considering this package to simplify the solution and make it more robust: https://github.com/cenkalti/backoff

I am not really sure if we need exponential backoff here. This is currently problem with connection to our settlement layer. We dont really have any rate-limiting on geth. So the only reason I see this dropping is because of connection drop on client side. So not sure if exponential backoff will help. Wdyt?

You don't have to opt for exponential repetition, the package is flexible enough so that it can be set to fixed periodic repetition.