primitivefinance / DFMM

Smart contracts of the DFMM protocol
https://www.primitive.xyz/blog/dfmm_protocol
18 stars 6 forks source link

bug: constant sum deallocate events log `deltas[]` as null #133

Open zachdt opened 3 months ago

zachdt commented 3 months ago

Deallocate events log deltas[] as null on the constant sum strategy.
https://optimism-sepolia.blockscout.com/tx/0x2666757a1481cfefcbd1593fb9bf9d41e62272609668c9b8aeb434e47f69d545?tab=logs

May be related to not leaving dust in the other side of the pool in constant sum, but I need assistance replicating this bug across other strategies, as we do not have production deallocate events on NG3M or LogNormal.

As a may-be-related note, it is unclear to me why Deallocate events index deltas[] but Allocate events do not.