primocms / primo

Primo is a visual CMS with a built-in code editor, Svelte blocks, and static site generator.
https://primocms.org
MIT License
1.92k stars 474 forks source link

Could not deploy to repo #365

Open vednolacni opened 6 months ago

vednolacni commented 6 months ago

Like the title. I tried new primo server with new supabase and new github token but still couldnt make it work.

image

vednolacni commented 6 months ago

image There is also the problem of selecting old repos... it wont show them.

mateomorris commented 6 months ago

Weird. Are you sure you have full repo permissions on the token? Are there any error in the console?

vednolacni commented 6 months ago

Weird. Are you sure you have full repo permissions on the token? Are there any error in the console?

Here are my permissions. image

My browser console when i want to deploy: image

vednolacni commented 6 months ago

and today after the update it gives me this:

image

vednolacni commented 6 months ago

and if i want to download it directly:

image

rmill2016 commented 6 months ago

after before

I'm running into the same issue, fresh install, one site completed and tried deploying. I'm not able to download or deploy currently. Also, making changes to the primo server doesn't update the site repo, need to delete and recreate for each change...

mateomorris commented 6 months ago

image There is also the problem of selecting old repos... it wont show them.

This sseems to be a different issue. Are there any console errors?

mateomorris commented 6 months ago

@vednolacni @rmill2016 those errors seem to be coming from the Blocks - might be worth checking your pages to see if any Blocks are missing data. For example, Cannot read properties of undefined (reading 'alt') means it's trying to compile a Block, but the image field doesn't have a value. You might be able to track it down by clicking the file link.

mateomorris commented 6 months ago

Also, making changes to the primo server doesn't update the site repo, need to delete and recreate for each change...

@rmill2016 can you elaborate on what you mean?

rmill2016 commented 6 months ago

@mateomorris Hey! Thanks for the headsup, that makes much more sense. I was able to resolve the undefined error and able to download the repository. Although I'm still not able to deploy to a new or existing repo. Primo does, however initialize the repo with a README.md file. update update2

rmill2016 commented 6 months ago

I'm investigating the issue further, seems that the POST endpoint for Netlify web host isn't /api/deploy but instead /api/v1/deploy

https://docs.netlify.com/api/get-started/#deploy-with-the-api

@vednolacni Are you perhaps deploying to Netlify as well? Or Vercel?

Edit: It seems after further searching, there was previously an issue with Netlify in the past. Resolved using the file digest method, are you able to confirm Netlify is the issue. I will try to deploy to Vercel now. 👍 Edit 2: Not able to deploy to Vercel either currently.

Tobarrientos2 commented 6 months ago

@rmill2016 I'm experiencing the same problem. I'm unable to deploy to a new repository from Vercel. Have you discovered a solution for this issue?

mateomorris commented 6 months ago

@rmill2016 note that Primo isn't interacting with Netlify/Vercel's API directly (it used to, but not anymore). The POST shown in your screenshot is your browser building the files and sending them to your server's backend (e.g. myprimoserver.vercel.app/api/deploy), which it has to do since your Github token isn't sent to the browser, so the files generated in the browser need to be sent to the backend to get sent along to Github.

Are you able to create a brand new site & publish it to a repo without issue?

vednolacni commented 5 months ago

I tried crating a new page and a new primo server but still cant deploy any site.

I dont use Netlify or Vercel.

mateomorris commented 5 months ago

@vednolacni where are you deploying your Primo server to?

vednolacni commented 5 months ago

@vednolacni where are you deploying your Primo server to?

cloudflare pages