search

prince-chrismc / conan-center-index-pending-review

A simple repository to automatically track which conan-center-index pull requests are ready for review
https://prince-chrismc.github.io/conan-center-index-pending-review/
MIT License
14 stars 1 forks source link

make team reviews bold #150

Closed ericLemanissier closed 11 months ago

ericLemanissier commented 12 months ago

blocked by:

prince-chrismc commented 12 months ago

You'll need to update some tests with the new format https://github.com/prince-chrismc/conan-center-index-pending-review/blob/91b09c7f93356647c26959768f4f605091524c5a/internal/format/reviews_test.go#L108

codecov-commenter commented 12 months ago

Codecov Report

Merging #150 (96a0c7e) into main (e35621d) will increase coverage by 0.13%. Report is 2 commits behind head on main. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   56.42%   56.56%   +0.13%     
==========================================
  Files          18       18              
  Lines         638      640       +2     
==========================================
+ Hits          360      362       +2     
  Misses        241      241              
  Partials       37       37
Files Changed Coverage Δ
internal/format/reviews.go 84.76% <50.00%> (+0.29%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ericLemanissier commented 12 months ago

@prince-chrismc the token used for the failing job (commit) is github.token which grants only 1000 requests, contrary to the token used in run job secrets.REPO_PAT which grants 5000 requests. Do you want to use secrets.REPO_PAT for the two jobs, or do we merge it like that ?

prince-chrismc commented 11 months ago

Dependabot doesn't have access to the secrets unfortunately 😕

I merge them if the test changes are ran which in this case they are