Add Dark Mode to the Interactive Demo Site

princefishthrower / react-use-please-stay

A React hook that animates the document title and/or favicon when focus from the page is lost.

MIT License

152 stars 7 forks source link

Add Dark Mode to the Interactive Demo Site #4

Closed princefishthrower closed 3 years ago

princefishthrower commented 3 years ago

Just a fun one, and perfect for the October season (at least for those of us in the northern hemisphere 😉 ). I'd like to add a dark mode toggler to the interact demo site!

This would include:

Adding a header component to the demo site
Adding a toggle button to switch from dark to light modes
This toggler should detect the preferred mode automatically - not sure if this one is even possible, we have to look - at the very least the preference should be saved in a cookie when toggled

AbhimanyuBahree commented 3 years ago

@princefishthrower I would like to take this up.

princefishthrower commented 3 years ago

@babu1998 go for it! I've assigned you to this issue.

AbhimanyuBahree commented 3 years ago

to clarify I have to add the toggle button in the header component?

princefishthrower commented 3 years ago

Yes, my hope was that part of this pull request a header would be added to the interactive demo site, since there isn't one yet. I may add another issue later to add things to this header, like a link to github etc

camperjett commented 3 years ago

Is it necessary to get assigned to this issue in order to create a pr?

AbhimanyuBahree commented 3 years ago

I am working on this @camperjett

princefishthrower commented 3 years ago

@camperjett - assignment isn't needed to create a PR technically, but I'll be taking the PR from @babu1998 since I think a first come first serve process is the only fair way here.

princefishthrower commented 3 years ago

@babu1998 - I left a small change request on your PR.