princejwesley / Mancy

>_ Electron based NodeJS REPL :see_no_evil:
http://mancy-re.pl
MIT License
2.63k stars 133 forks source link

NODE_ENV #152

Open sbuljac opened 8 years ago

sbuljac commented 8 years ago

When I try to set process.env.NODE_ENV = 'development' it just get blocked.

princejwesley commented 8 years ago

@sbuljac problem is in 'react.js' interaction.

// ReactMount.js
if ("production" !== process.env.NODE_ENV) {
  /** __DEV__-only mapping from reactRootID to root elements. */
  var rootElementsByReactRootID = {}; // this variable is not available when we switch to development
}

[(set here)](https://github.com/princejwesley/Mancy/blob/cd0bc938dce89a171b09f0862e22d143c8769eb1/src/Startup.js#L3) -- this is an old comment (console instances are decoupled long back and removing this line will fix #152

Unfortunately process instance is shared between app and user context. I'll look into that
princejwesley commented 8 years ago

Issue is fixed in master.

sbuljac commented 8 years ago

Ok, thx