princejwesley / minimap

A preview of full webpage or its DOM element with flexible positioning and navigation support
http://www.toolitup.com/minimap.html
MIT License
244 stars 51 forks source link

Bug with fixed elements #2

Closed csoLs closed 9 years ago

csoLs commented 9 years ago

White and light-gray elements are fixed elements with full width/height. They obviously don't look that nice on the minimap. temp-git

princejwesley commented 9 years ago

Can you provide more information? Thanks

princejwesley commented 9 years ago

Closing this for now

csoLs commented 9 years ago

Sure, what do you want to know? I solved this problem by hiding them completely on the minimap, but if someone want them rendered shouldn't they be positioned correctly? Say you have an element fixed to the bottom of your page, you probably would want it at the bottom of the minimap too, regardless of the document height (as seen in my provided image, the fixed element is hovering at the center of the minimap).

princejwesley commented 9 years ago

Got it! Your bug report makes sense now.

princejwesley commented 9 years ago

Passed $minimap and scale object to onPreviewChange callback to let user handle unresponsive layouts.