Country details issue - Githubissues

princemuel / rest-countries

Harnessing the power of the REST Countries API, this application provides comprehensive and up-to-date information about any country

https://rest-countries-mocha.vercel.app

2 stars 1 forks source link

Closed PradnyaB17 closed 1 year ago

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @princemuel on Vercel.

@princemuel first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rest-countries	❌ Failed (Inspect)			Sep 8, 2023 8:50pm

princemuel commented 1 year ago

Hi. I have some suggestions.

Please type the set as a string set, as the typescript issue is causing the deployment to fail
The object values can be a oneliner. The set can then filter out the duplicate values in the array
```
const nativeNameList = Object.values(country?.name?.nativeName || {}).map((name) => name.common)
```
For commit 2b43f37, maybe use an alternative solution for the text wrapping. The text-wrap CSS property is not widely supported by major browsers.

princemuel commented 1 year ago

fixes issue #13

princemuel commented 1 year ago

@pradnyabhukan 👍🏼 🔥