search

princeton-nlp / CoFiPruning

[ACL 2022] Structured Pruning Learns Compact and Accurate Models https://arxiv.org/abs/2204.00408
MIT License
188 stars 32 forks source link

[Typo]: argument names in run_qa_prune.py seems not updated #45

Open sbwww opened 1 year ago

sbwww commented 1 year ago

The argument has an attribute of do_distill

https://github.com/princeton-nlp/CoFiPruning/blob/793e3e1291827e2714b5de6d5c0b6b04bc1863e4/args.py#L43

while in run_qa_prune.py, do_distil (missing an 'l') is used

https://github.com/princeton-nlp/CoFiPruning/blob/793e3e1291827e2714b5de6d5c0b6b04bc1863e4/run_qa_prune.py#L101

sbwww commented 1 year ago

It seems that run_qa_prune.py is not updated after the argument names are changed. Such as

https://github.com/princeton-nlp/CoFiPruning/blob/793e3e1291827e2714b5de6d5c0b6b04bc1863e4/run_qa_prune.py#L139

str_pruning_method should be pruning_type

https://github.com/princeton-nlp/CoFiPruning/blob/793e3e1291827e2714b5de6d5c0b6b04bc1863e4/run_glue_prune.py#L226