Don't let tox install a virtualenv during evaluation

princeton-nlp / SWE-bench

[ICLR 2024] SWE-Bench: Can Language Models Resolve Real-world Github Issues?

https://www.swebench.com

MIT License

1.5k stars 247 forks source link

Don't let tox install a virtualenv during evaluation #171

Closed waterson closed 2 weeks ago

waterson commented 2 weeks ago

By default, tox will try to create a virtualenv in which to reinstall all of the dependencies. We don't need this level of isolation for SWE-bench, so use the tox-current-env plugin to elide that.

Reference Issues/PRs

Fixes #170.

What does this implement/fix? Explain your changes.

Use the tox-current-env plugin to tell tox not to try to install its own venv.

Any other comments?

🧡 Thanks for contributing!

ofirpress commented 2 weeks ago

Thanks Chris!

john-b-yang commented 2 weeks ago

Sweet thanks for the catch @waterson! LGTM + merged. Just took a look at an execution log as well and saw the same original behavior.