princeton-nlp / SimCSE

[EMNLP 2021] SimCSE: Simple Contrastive Learning of Sentence Embeddings https://arxiv.org/abs/2104.08821
MIT License
3.33k stars 505 forks source link

code bug #186

Closed IT-coach-666 closed 2 years ago

IT-coach-666 commented 2 years ago

In line 214 of the simcse/tool.py: lack of threshold and top_k parameters. results = self.search(query, device)

It should be: results = self.search(query, device, threshold, top_k)

gaotianyu1350 commented 2 years ago

Thanks for your feedback. The bug has been fixed.