princeton-nlp / WebShop

[NeurIPS 2022] 🛒WebShop: Towards Scalable Real-World Web Interaction with Grounded Language Agents
https://webshop-pnlp.github.io
MIT License
269 stars 56 forks source link

[Installation Issues] - Arm-based Mac (M1, M2, M3); faiss-cpu; Werkzeug.urls, spacy #33

Closed ai-nikolai closed 2 months ago

ai-nikolai commented 5 months ago

Various Installation Issues (especially on arm-based mac).

What is the current behavior?

Steps to Reproduce

./setup.sh

What is the expected behavior?

It should install OOB on arm-based Mac (and other platforms).

Motivation for Change

Not installing properly and so not usable.

Please tell us about your environment:

ai-nikolai commented 5 months ago

@karthikncode @CodeCreator @danqi @ysymyth - this PR is a fix to the above problem (and probably fixes on other envs as well).

PR that fixes the issue: https://github.com/princeton-nlp/WebShop/pull/34

The changes are documented in README_INSTALL_ARM_MAC.md.

In addition changed: download en_core_web_lg to download en_core_web_sm (as download en_core_web_lg is probably slightly deprecated on Spacy's side and is taking ages to download.) if a more powerful model is needed I would recommend: download en_core_web_trf.

ysymyth commented 2 months ago

thank you! have merged.

ai-nikolai commented 2 months ago

@ysymyth thanks for merging. As mentioned in the comment above in the PR:

I changed: download en_core_web_lg to download en_core_web_sm (as download en_core_web_lg is probably slightly deprecated on Spacy's side and is taking ages to download.) if a more powerful model is needed I would recommend: download en_core_web_trf.

What do you think?