search

princeton-vl / DROID-SLAM

BSD 3-Clause "New" or "Revised" License
1.65k stars 272 forks source link

Is that an issue in rm_keyframe function? #129

Open herezt opened 3 weeks ago

herezt commented 3 weeks ago 
    with self.video.get_lock():
        self.video.images[ix] = self.video.images[ix+1]
        self.video.poses[ix] = self.video.poses[ix+1]
        self.video.disps[ix] = self.video.disps[ix+1]
        self.video.disps_sens[ix] = self.video.disps_sens[ix+1]
        self.video.intrinsics[ix] = self.video.intrinsics[ix+1]

        self.video.nets[ix] = self.video.nets[ix+1]
        self.video.inps[ix] = self.video.inps[ix+1]
        self.video.fmaps[ix] = self.video.fmaps[ix+1]

self.video.tstamp is not modified. That will mess up releatioships between timestamps and other fields.

aabbas90 commented 1 week ago

See https://github.com/princeton-vl/DROID-SLAM/pull/53