animation rigs is correct only on fish

princeton-vl / infinigen

Infinite Photorealistic Worlds using Procedural Generation

https://infinigen.org

BSD 3-Clause "New" or "Revised" License

5.32k stars 455 forks source link

animation rigs is correct only on fish #89

Closed JiazheZhang closed 1 year ago

JiazheZhang commented 1 year ago

Hi, after I change the code, I tested the function of join_and_rig_parts. (I add 'self.animation_mode="run"' on the line 209 in worldgen\assets\creatures\genomes\herbivore.py) I found that the animation rigs is correct only on fish, while rigging on other animals can lead to distortion of the model. I wonder the root cause, and I'd like to know if you will make optimizations in the future?

araistrick commented 1 year ago

Thanks for raising this, I thought all were working but I will test and fix asap. I will fix this as soon as possible

araistrick commented 1 year ago

I fixed an issue with the tiger IKs and verified that animation_mode='run' is at least funcitonal (if not the the most realistic, Id love to revisit / improve this later). Let me know what if any specific issues still persist