princeton-vl / pose-hg-demo

Code to test and use the model from "Stacked Hourglass Networks for Human Pose Estimation"
BSD 3-Clause "New" or "Revised" License
316 stars 86 forks source link

Torch max function update #7

Closed gulvarol closed 7 years ago

gulvarol commented 7 years ago

Hi Alejandro,

I guess you updated the training code to work with the updated 'max' function which doesn't return index anymore. (with this commit)

But it doesn't seem to be updated in this demo repository. I haven't ran it myself, I just realized looking at the code.

anewell commented 7 years ago

Thanks for pointing that out, I think I didn't change it here since the bug only affected the on-the-fly accuracy calculation which doesn't get computed here. I've updated it to keep things consistent.

anibali commented 7 years ago

@anewell I think that your update addressing this issue is affecting the results adversely. See https://github.com/anewell/pose-hg-demo/pull/14.