Broken image in lectures/flow/switch

princomp / princomp.github.io

Teaching material for the principles of computer programming using C#.

https://princomp.github.io/

Creative Commons Attribution 4.0 International

0 stars 1 forks source link

Broken image in lectures/flow/switch #23

Open jweeks2023 opened 3 months ago

jweeks2023 commented 3 months ago

https://github.com/princomp/princomp.github.io/blob/0d923a06743e326758087d757aa12bcd0898987f/source/lectures/flow/switch.md?plain=1#L13

aubertc commented 3 months ago

https://github.com/princomp/princomp.github.io/commit/ddd2cd04c4b8b16ed777cfc5436c267a2f7c7451 will solve that.

jweeks2023 commented 3 months ago

It is fixed, however, it seems this image is not accessible for dark mode users. See picture below:

jweeks2023 commented 3 months ago

This is actually a widespread issue with these diagrams, which I believe are related to the fact that you are using SVGs for these. There are multiple ways to approach this (i.e., add backgrounds to them, modify the color scheme to have light and dark variants, etc.), but each solution has its pros and cons, so I will leave that to you to decide how to proceed.

aubertc commented 3 months ago

Ok, I'll try to think of a global solution.