printdotio / pio.js

An embeddable widget that enables users to quickly and easily monetize a webpage by enabling photo-product sales of its images.
4 stars 0 forks source link

Does "fadeBackground: false" still have any effect? #76

Closed ocram closed 9 years ago

ocram commented 9 years ago

In your docs, you describe that one can use fadeBackground: true to "turn off the black background".

But we can't see any effect. Could you clarify whether this does still work and where we can see the effect of this setting?

bhox commented 9 years ago

Investigating

bhox commented 9 years ago

It seems to work okay to hide the lightbox in the example in page: http://print.io/platform-web-customization

ocram commented 9 years ago

Thank you! So this does only affect the lightbox/fancybox? I'm using the embedInElement: element property and was wondering what background this refers to.

bhox commented 9 years ago

Yeah, it doesn't do anything if the widget is embedded since there is no light/fancybox to hide. Is there an effect you were working on that I can help with?

ocram commented 9 years ago

No, that's fine. I was just wondering.

I'm going to close this issue as my question has been answered. Maybe you should add this piece of context to your documentation, i.e. that this affects the lightbox/fancybox.

bhox commented 9 years ago

Great feedback, will add the clarification, thanks!