search

printdotio / printio-api

Issues + wiki for the api. See http://print.io/api
0 stars 0 forks source link

Stark differences between Swagger Schema and Server Responses: "/productvariants" #6

Closed terhechte closed 9 years ago

terhechte commented 9 years ago

Hey, I'm currently implementing the API for a Mac OS X app, and started by auto-generating code with swagger-codegen based on the current /api docs. Apart from the fact that the generated code needed a lot of customization to actually compile (I didn't created tickets for this yet, as it is in part a Swagger-Codegen problem, too; I remember that I've had similar issues with objc generation in previous projects that used Swagger APIs), there seem to be quite some differences between server responses and Swagger schema. If its ok, I'll just create tickets whenever I stumble upon such differences.

/productvariants list the following attributes for "ProductOption": class ProductOption(OptionId: string, ValueId: string, Name: string, Value: string, IconUrl: string, IconType: string, ColorRgba: string)

However, the server reply dictionary for a product option object is as follows:

{ "OptionId": "c02deea045fb4d47873985b333db9321", "ValueId": "284ec9da7e66449a859ac08bb9ce51b7", "Name": "Print Type", "Value": "Gloss", "ImageUrl": "http://app-imgs.print.io/product-framedprints/glossprint.png", "ImageType": "WebImg", "SortValue": "1" },

IconType != ImageType, IconUrl != ImageUrl, ColorRgba doesn't appear, and SortValue is unlisted.

Cheers, Benedikt

micahasmith commented 9 years ago

will take a look. thx--

terhechte commented 9 years ago

There's another new field on ProductOption which I forgot about: CmValue.

Thanks!

micahasmith commented 9 years ago

i've started going through all of the endpoints' models, will try to get all updated everywhere

terhechte commented 9 years ago

Awesome, thanks.

micahasmith commented 9 years ago

@terhechte all updated. let me know any further issues