search

printdotio / printio-ios-sdk

SDK that enables the printing of any photo, from any source, onto any product!
Other
20 stars 11 forks source link

Status bar overlays content, and occasionally doesn't match the application orientation #449

Closed arik-so closed 8 years ago

arik-so commented 9 years ago

Status bar orientation mismatch: image

Status bar content overlay: image

AustenB commented 9 years ago

What device is this on? What iOS version?

Do you want to show the status bar or would you want to hide it during the commerce process?

Do you show the status bar in your host app or do you hide it?

On Thu, Jun 25, 2015 at 12:02 PM, Arik Sosman notifications@github.com wrote:

Status bar orientation mismatch: [image: image] https://cloud.githubusercontent.com/assets/927534/8359053/d3068626-1b18-11e5-92ce-e36990c72270.png

Status bar content overlay: [image: image] https://cloud.githubusercontent.com/assets/927534/8359060/dec13fd8-1b18-11e5-8583-7405ece7cdcc.png

— Reply to this email directly or view it on GitHub https://github.com/printdotio/printio-ios-sdk/issues/449.

Austen Bernstein Founder & CEO printio

arik-so commented 9 years ago

It is on the iPhone 5s, and the iOS version is 8.3. It appears to me personally that in the first screen, it would make more sense to hide the status bar, whereas in the second screen, it would probably suffice to move the top buttons down a bit.

AustenB commented 9 years ago

Our team will look into this asap and get back to you. This could be a status bar bug - as it should always be hidden on the customization screen.

On Thu, Jun 25, 2015 at 1:21 PM, Arik Sosman notifications@github.com wrote:

It is on the iPhone 5s, and the iOS version is 8.3. It appears to me personally that in the first screen, it would make more sense to hide the status bar, whereas in the second screen, it would probably suffice to move the top buttons down a bit.

— Reply to this email directly or view it on GitHub https://github.com/printdotio/printio-ios-sdk/issues/449#issuecomment-115329862 .

Austen Bernstein Founder & CEO printio

arik-so commented 9 years ago

It might very well be a status bar bug. If it is, there is another minor issue: the method

[printIO setStatusBarDark:YES hidden:YES];

does not, when hidden is set to NO, change the status bar text color to white regardless of whether setStatusBarDark is set to YES or NO, and additionally, when hidden is set to YES, the status bar still remains visible at all times.

AustenB commented 9 years ago

Tag this as a separate github ticket. We will take a look at this also. Perhaps we need to give better instructions how to use the method.

On Thu, Jun 25, 2015 at 1:30 PM, Arik Sosman notifications@github.com wrote:

It might very well be a status bar bug. If it is, there is another minor issue: the method

[printIO setStatusBarDark:YES hidden:YES];

does not, when hidden is set to NO, change the status bar text color to white regardless of whether setStatusBarDark is set to YES or NO, and additionally, when hidden is set to YES, the status bar still remains visible at all times.

— Reply to this email directly or view it on GitHub https://github.com/printdotio/printio-ios-sdk/issues/449#issuecomment-115336386 .

Austen Bernstein Founder & CEO printio

offirg1 commented 9 years ago

It's also happens on iOS6

AustenB commented 9 years ago

please email the initialization code you are using to this to Boro and we will try to solve tomorrow.

On Thu, Jun 25, 2015 at 7:47 PM, offirg1 notifications@github.com wrote:

It's also happens on iOS6

— Reply to this email directly or view it on GitHub https://github.com/printdotio/printio-ios-sdk/issues/449#issuecomment-115432097 .

Austen Bernstein Founder & CEO printio

perisicboro commented 9 years ago

@offirg1 @arik-so Do you show the status bar in your host app or do you hide it?

By default status bar is visible in SDK, use method:

[printIO setStatusBarDark:YES hidden:YES];

to hide it. In general it works in our sample app, but we had cases where status bar visibility not acting as expected. So if you set it hidden, and it's still visible in sdk, then do not use method above to hide it. In this way you would avoid issues like on second screenshot.

For photobooks: status bar bug is fixed, and will be available in next update.

offirg1 commented 9 years ago

We show it

Sent from my iPhone

On Jun 26, 2015, at 6:13 AM, perisicboro notifications@github.com wrote:

@offirg1 @arik-so Do you show the status bar in your host app or do you hide it?

By default status bar is visible in SDK, use method:

[printIO setStatusBarDark:YES hidden:YES]; to hide it. In general it works in our sample app, but we had cases where status bar visibility not acting as expected. So if you set it hidden, and it's still visible in sdk, then do not use method above to hide it. In this way you would avoid issues like on second screenshot.

For photobooks: status bar bug is fixed, and will be available in next update.

— Reply to this email directly or view it on GitHub.

perisicboro commented 9 years ago

If SDK can't hide status bar using method from comment above, then just don't use that method, and sdk will work with visible status bar.

AustenB commented 9 years ago

@perisicboro i think they are saying the status bar is showing on top of the nav buttons - we had this issue in 2014.

On Fri, Jun 26, 2015 at 9:26 AM, perisicboro notifications@github.com wrote:

If SDK can't hide status bar using method from comment above, then just don't use that method, and sdk will work with visible status bar.

— Reply to this email directly or view it on GitHub https://github.com/printdotio/printio-ios-sdk/issues/449#issuecomment-115684319 .

Austen Bernstein Founder & CEO printio

perisicboro commented 9 years ago

@AustenB Hiding status bar doesn't work them, that's why it's showing on top of buttons. solution is not to try to hide it, just not to use that method.

AustenB commented 9 years ago

@offirg1 You heard it here. Don't use that method.

On Fri, Jun 26, 2015 at 10:26 AM, perisicboro notifications@github.com wrote:

@AustenB https://github.com/AustenB Hiding status bar doesn't work them, that's why it's showing on top of buttons. solution is not to try to hide it, just not to use that method.

— Reply to this email directly or view it on GitHub https://github.com/printdotio/printio-ios-sdk/issues/449#issuecomment-115707526 .

Austen Bernstein Founder & CEO printio

offirg1 commented 9 years ago

@arik-so

Sent from my iPhone

On Jun 26, 2015, at 7:32 AM, Austen Bernstein notifications@github.com wrote:

@offirg1 You heard it here. Don't use that method.

On Fri, Jun 26, 2015 at 10:26 AM, perisicboro notifications@github.com wrote:

@AustenB https://github.com/AustenB Hiding status bar doesn't work them, that's why it's showing on top of buttons. solution is not to try to hide it, just not to use that method.

— Reply to this email directly or view it on GitHub https://github.com/printdotio/printio-ios-sdk/issues/449#issuecomment-115707526 .

Austen Bernstein Founder & CEO printio — Reply to this email directly or view it on GitHub.

perisicboro commented 9 years ago

Fixed in latest SDK version.