search

printdotio / printio-ios-sdk

SDK that enables the printing of any photo, from any source, onto any product!
Other
20 stars 11 forks source link

Broken framework search path override in podspec #528

Closed berendo closed 7 years ago

berendo commented 7 years ago

The following lines in the podspec for CocoaPods integration:

https://github.com/printdotio/printio-ios-sdk/blob/91abd2395680d4a8b56a8ed09d4f38a5ca08fe47/PrintIO.podspec#L37-L39

override the framework search paths incorrectly (and unncecessarily) and interfere with compiling with other frameworks provided via CocoaPods. For example, merely adding the line:

  pod 'PrintIO'

to our existing Podfile, results in compilation failing with headers related to Twitter's Crashlytics framework not being found via the project's precompiled prefix header:

.../Disneyland-Prefix.pch:15:13: fatal error: 'Crashlytics/Crashlytics.h' file not found
    #import <Crashlytics/Crashlytics.h>
            ^
1 error generated.

Using a local copy of the PrintIO.podspec with the lines overriding FRAMEWORK_SEARCH_PATHS and OTHER_LDFLAGS removed results in successful compilation, including use of the PrintIO framework.

Those lines should be removed from the podspec file and the pod command should be left to its elements to set up the search paths for frameworks. In case it's relevant to reproducing this issue, pod --version reports 1.2.1.

perisicboro commented 7 years ago

With next sdk update, we will take a look at this issue.

perisicboro commented 7 years ago

Fixed.

berendo commented 7 years ago

Thanks! The latest PrintIO.podspec works great.