Closed frectonz closed 4 months ago
Attention: Patch coverage is 68.75000%
with 20 lines
in your changes are missing coverage. Please review.
Project coverage is 83.30%. Comparing base (
7dce963
) to head (c3e7795
).
Files | Patch % | Lines |
---|---|---|
core/src/ast.rs | 38.09% | 13 Missing :warning: |
core/src/num/unit.rs | 40.00% | 3 Missing :warning: |
core/src/lexer.rs | 71.42% | 2 Missing :warning: |
core/src/scope.rs | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Wow, you’re on a roll with all the things you’ve been implementing recently. Thanks so much for all your work!! I’ve left a small comment to improve the equality checks a bit, but otherwise your implementation looks excellent!
thanks for the kind words :pray: and btw i also implemented inequality
Comparisons of different units is now implemented 🎉
Potential implementation of #229 I used the regular rust way of
PartialEq
andEq
to check for equality.