search

printprobability / qa-workflow

Quality Assurance testing for the Print & Probability book processing and ingestion pipeline
MIT License
0 stars 0 forks source link

Revise run method for Eynollah QA #24

Closed jarmoza closed 7 months ago

jarmoza commented 8 months ago

Now that we have Eynollah running, reimplement running eynollah from the QA module so that it calls line_extract_eynollah_all.sh for a collection of books or run_workflow1_eynollah.sh for many books.

jarmoza commented 7 months ago

Created separate issue for cleaning up and documenting the Eynollah scripts themselves. Moving the above comments/tasks here: https://github.com/orgs/printprobability/projects/1/views/1?pane=issue&itemId=51682396

jarmoza commented 7 months ago

Running Eynollah with QA just uses the base run method for QA line extraction and – other than qa_line_extraction_eynollah.sh to directly call Eynollah – does not use a separate QA shell script to call a main run function qa_line_extraction.py like QA does for watershed. (That previous way of running autocrop/watershed was a bit convoluted and should perhaps be brought to behave like Eynollah does.)

jarmoza commented 7 months ago

The current method of running Eynollah QA is implemented as of https://github.com/printprobability/qa-workflow/commit/34117f4740d9f071fa0a6998d7fa9fc6cdda30db and the old commented out version of this functionality was removed here: https://github.com/printprobability/qa-workflow/commit/3e85e3c845f5714b849632dadd1d1f46c559d6f1